Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Next.js] Personalize Middleware updates to handle Component A/B Testing #1848

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

ambrauer
Copy link
Contributor

Description / Motivation

Updates to Next.js personalize middleware and supporting utilities / services for Component A/B Testing.
Includes an upgrade to @sitecore-cloudsdk/personalize / @sitecore-cloudsdk/events v0.3.1.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@ambrauer ambrauer requested a review from a team July 22, 2024 21:32
@ambrauer ambrauer changed the title [Next.js] Personalize Middleware updated to handle Component A/B Testing [Next.js] Personalize Middleware updates to handle Component A/B Testing Jul 22, 2024
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Please, review my comments/suggestions below

Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this good to go. I left some comments which would probably not affect the implementation much, but worth taking a look at.

Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍
Don't forget to remove ".only" call

packages/sitecore-jss/src/personalize/utils.test.ts Outdated Show resolved Hide resolved
@ambrauer ambrauer merged commit bd5ebb3 into dev Jul 23, 2024
1 check passed
@ambrauer ambrauer deleted the feature/JSS-3338 branch July 23, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants