-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Next.js] Personalize Middleware updates to handle Component A/B Testing #1848
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Please, review my comments/suggestions below
packages/sitecore-jss/src/personalize/graphql-personalize-service.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/personalize-middleware.ts
Outdated
Show resolved
Hide resolved
...s/create-sitecore-jss/src/templates/nextjs-xmcloud/src/lib/middleware/plugins/personalize.ts
Outdated
Show resolved
Hide resolved
… for component A/B testing
…ing of variantIds to personalize call from middleware
8fecf5e
to
57267ac
Compare
packages/sitecore-jss-nextjs/src/services/base-graphql-sitemap-service.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this good to go. I left some comments which would probably not affect the implementation much, but worth taking a look at.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👍
Don't forget to remove ".only" call
Description / Motivation
Updates to Next.js personalize middleware and supporting utilities / services for Component A/B Testing.
Includes an upgrade to
@sitecore-cloudsdk/personalize
/@sitecore-cloudsdk/events
v0.3.1.Testing Details
Types of changes