Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editing Integration] Add editMode to /editing/config endpoint response with configurable integration option #1803

Merged
merged 8 commits into from
May 28, 2024
Merged

[Editing Integration] Add editMode to /editing/config endpoint response with configurable integration option #1803

merged 8 commits into from
May 28, 2024

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented May 23, 2024 •
edited by yavorsk
Loading

Description / Motivation

We need to enhance the /editing/config feature detection endpoint and to support the new integration. This will allow Pages to detect whether the new integration is supported or not.

  • Added a pagesEditMode to the sample to disbale/enable the new editing experience for Pages
  • /editing/config endpoint now returns editMode with metadata response.
  • It returns metadata by default.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania changed the title [sitecore-jss-nextjs] [template/nextjs-xmcloud] Editing Flip - editMode detection and integration toggle for /editing/config endpoint [Editing Integration] editMode detection and integration toggle for /editing/config endpoint May 23, 2024
@addy-pathania addy-pathania changed the title [Editing Integration] editMode detection and integration toggle for /editing/config endpoint [Editing Integration] editMode detection and integration toggle for /editing/config endpoint May 23, 2024
@addy-pathania addy-pathania changed the title [Editing Integration] editMode detection and integration toggle for /editing/config endpoint [Editing Integration] Add editMode to /editing/config endpoint response with configurable integration option May 23, 2024
@addy-pathania addy-pathania requested a review from a team May 24, 2024 12:06
illiakovalenko
illiakovalenko approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved
See few minor comments below

docs/upgrades/unreleased.md Outdated Show resolved Hide resolved
docs/upgrades/unreleased.md Show resolved Hide resolved
@addy-pathania addy-pathania merged commit 390e68c into dev May 28, 2024
1 check passed
@addy-pathania addy-pathania deleted the feature/jss-2950-editing-flip-config-endpoint branch May 28, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer left review comments

@illiakovalenko illiakovalenko illiakovalenko approved these changes

@art-alexeyenko art-alexeyenko Awaiting requested review from art-alexeyenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addy-pathania @ambrauer @art-alexeyenko @illiakovalenko