[sitecore-jss-react] ErrorBoundary nested components fix #1799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
This PR is a follow up to #1786 . It aims to fix an issue in the case where parent component is being used with withPlaceholder HOC and references its child components' props (this issue was caught in automated rendering tests for styleguide tabs component); since each child component is wrapped by ErrorBoundary, this adds additional level of nesting and changes the way parent should access its children's props; this is solved by exposing components props inside the error boundary.
This PR also:
Testing Details
Types of changes