[sitecore-jss-nextjs][sitecore-jss] multi-origin CORS validation for next editing middlewares #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation and apply it to next editing middlewares
illiakovalenko
requested changes
May 20, 2024
packages/sitecore-jss-nextjs/src/editing/editing-config-middleware.ts
Outdated
Show resolved
Hide resolved
yavorsk
requested changes
May 20, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
CORS configuration through next config only allows to set a single allowed origin - or a wildcard.
JSS editing API endpoints require a more sophisticated configuration. This PR adds a function to validate incoming origin against multiple possible values, with an option to configure more allowed origins through env variable.
It also applies this CORS validation function to editing middleware handlers:
Testing Details
Types of changes