Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nextjs][RAV] avoid unexpected linebreaks when generating config #1791

Merged
merged 3 commits into from
May 9, 2024
Merged

[nextjs][RAV] avoid unexpected linebreaks when generating config #1791

merged 3 commits into from
May 9, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented May 8, 2024 •
edited
Loading

Description / Motivation

An extra trim() call in generate-config scripts to cleanup any unwanted whitespace characters.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate):
  • nextjs app builds and works in prodcuction mode on macOS 15 and Windows
  • RAV apps work OK on MacOS 15 in disconnected mode

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team May 8, 2024 20:16
illiakovalenko
illiakovalenko approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! See one comment below

docs/upgrades/unreleased.md Outdated Show resolved Hide resolved
@art-alexeyenko art-alexeyenko merged commit 0165bb1 into dev May 9, 2024
1 check passed
@art-alexeyenko art-alexeyenko deleted the feature/jss-1618-writeConfig-redone branch May 9, 2024 14:06
@art-alexeyenko art-alexeyenko mentioned this pull request Jun 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art-alexeyenko @illiakovalenko