Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Rework temp config formatting #1787

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Apr 29, 2024

Description / Motivation

A small change to how temp/config files are formatted across apps in different frameworks.
This should prevent config files from being incorrectly imported on Unix systems.

Testing Details

  • Unit Test Added
  • Manual Test/Other - config being read correctly in disconnected mode across the board. Works in production in nexjts.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team April 29, 2024 22:32
docs/upgrades/unreleased.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in order to don't block PR
You can merge it after you apply the changes I mentioned above

@art-alexeyenko art-alexeyenko merged commit ac30356 into dev Apr 30, 2024
1 check passed
@art-alexeyenko art-alexeyenko deleted the feature/jss-1618-writeConfig-rework branch April 30, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants