Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] Replaced deprecated 'media' Styleguide-Image property by 'field' #1785

Merged
merged 2 commits into from
Apr 26, 2024
Merged

[React] Replaced deprecated 'media' Styleguide-Image property by 'field' #1785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88e6b77
Replaced deprecated _media_ styleguide image property by _field_
illiakovalenko Apr 26, 2024
0cebd48
Updated CHANGELOG
illiakovalenko Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Our versioning strategy is as follows:
* `sitecore-jss-nextjs` no longer exports `isEditorActive`, `resetEditorChormes`, `resolveUrl`, `handleEditorFastRefresh`, `getPublicUrl` functions. Use `sitecore-jss-nextjs/utils` instead.
* `getFEAASLibraryStylesheetLinks` function has been removed in favor of `getComponentLibraryStylesheetLinks`

* `[sitecore-jss-react]` Deprecated `media` prop is removed from Image component. Use `field` prop instead ([#1780](https://github.com/Sitecore/jss/pull/1780)).
* `[sitecore-jss-react]` `[templates/react]` Deprecated `media` prop is removed from Image component. Use `field` prop instead ([#1780](https://github.com/Sitecore/jss/pull/1780))([#1785](https://github.com/Sitecore/jss/pull/1785)).

* `[templates/react]` `[templates/angular]` `[templates/vue]` `[templates/node-headless-ssr-experience-edge]` `[sitecore-jss-react]` `[sitecore-jss-nextjs]` ([#1783](https://github.com/Sitecore/jss/pull/1783)):
* GraphQL-based services can now only be initialized with clientFactory parameter. Previously deprecated option of providing endpoint and apiKey has been removed
Expand Down
2 changes: 1 addition & 1 deletion ...ate-sitecore-jss/src/templates/react/src/components/fields/Styleguide-FieldUsage-Image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import StyleguideSpecimen from '../styleguide/Styleguide-Specimen';
const StyleguideFieldUsageImage = (props) => (
<StyleguideSpecimen {...props} e2eId="styleguide-fieldusage-image">
<p>Plain image</p>
<Image media={props.fields.sample1} />
<Image field={props.fields.sample1} />

{/*
Advanced image usage example
Expand Down