Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Removed deprecated props, updated samples to use clientFactory #1783

Merged
merged 5 commits into from
Apr 26, 2024
Merged

[Chore] Removed deprecated props, updated samples to use clientFactory #1783

merged 5 commits into from
Apr 26, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Apr 25, 2024 •
edited
Loading

  • This PR follows the Contribution Guide
  • Changelog updated
  • Upgrade guide entry added - added to upgrade guide

Description / Motivation

  • Updated RAV/node samples to use clientFactory
  • Removed deprecated defaultProps react component property

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko merged commit 6f3dd70 into dev Apr 26, 2024
1 check passed
@illiakovalenko illiakovalenko deleted the feature/JSS-1713-deprecations branch April 26, 2024 00:09
illiakovalenko added a commit that referenced this pull request Apr 26, 2024
@illiakovalenko
[Chore] Removed deprecated props, updated samples to use clientFactory (
d66f24c 
#1783)

* Updated Angular sample and exposed GraphQLRequestClient

* Upgraded React app, removed deprecated defaultProps property

* Updated node-headless-ssr-experience-edge and vue samples

* Updated comments

* Updated CHANGELOG
illiakovalenko added a commit that referenced this pull request Apr 26, 2024
@illiakovalenko
[Chore] Removed deprecated props, updated samples to use clientFactory (
a41c8bb 
#1784)

* [Chore] Removed deprecated props, updated samples to use clientFactory (#1783)

* Updated Angular sample and exposed GraphQLRequestClient

* Upgraded React app, removed deprecated defaultProps property

* Updated node-headless-ssr-experience-edge and vue samples

* Updated comments

* Updated CHANGELOG

* Updated CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@illiakovalenko