Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Security vulnerabilities audit #1778

Merged
merged 4 commits into from
Apr 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,15 @@ Our versioning strategy is as follows:

### 🛠 Breaking Changes

[sitecore-jss] Switch to edge site query for XP and gets config sites + sxa sites (ignoring website)
* [sitecore-jss] Switch to edge site query for XP and gets config sites + sxa sites (ignoring website)
* Previously introduced Boolean `useSiteQuery` switch for XMCloud users has been removed.
* Search query usage has been removed.
* If you have any non-nextjs sites they should filter them out in multisite config plugin

### 🧹 Chores

* Security vulnerabilities audit ([1778](https://github.com/Sitecore/jss/pull/1778))

## 21.7.1

### 🐛 Bug Fixes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"@sitecore-jss/sitecore-jss-proxy": "~21.8.0-canary",
"agentkeepalive": "^4.2.1",
"compression": "~1.7.4",
"express": "~4.18.2",
"express": "~4.19.2",
"memory-cache": "^0.2.0",
"dotenv": "^16.0.3"
},
Expand Down
40 changes: 20 additions & 20 deletions packages/sitecore-jss-dev-tools/.vscode/launch.json
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
{
"version": "0.2.0",
"configurations": [
{
"name": "Run mocha",
"type": "node2",
"request": "launch",
"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
"stopOnEntry": false,
"args": [
"--compilers",
"js:babel-core/register",
"./src/**/*.test.js",
"--no-timeouts",
"./dist/test"
],
"cwd": "${workspaceRoot}",
"runtimeExecutable": null
}
]
{
"version": "0.2.0",
"configurations": [
{
"name": "Run mocha",
"type": "node",
"request": "launch",
"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
"stopOnEntry": false,
"args": [
"--require",
"@babel/register",
"./src/**/*.test.js",
"--no-timeouts",
"./dist/test"
],
"cwd": "${workspaceRoot}",
"runtimeExecutable": null
}
]
}
3 changes: 2 additions & 1 deletion packages/sitecore-jss-dev-tools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@
"yargs": "^17.6.2"
},
"devDependencies": {
"@babel/core": "^7.24.4",
"@babel/register": "^7.23.7",
"@types/chai": "^4.3.4",
"@types/chokidar": "^2.1.3",
"@types/del": "^4.0.0",
Expand All @@ -71,7 +73,6 @@
"@types/url-join": "^4.0.1",
"@types/uuid": "^9.0.0",
"@types/yargs": "^17.0.22",
"babel-core": "^6.26.3",
"chai": "^4.3.7",
"cross-env": "^7.0.3",
"del-cli": "^5.0.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/sitecore-jss-dev-tools/src/pipelines/runner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ pipeline.addProcessor({
});

pipeline
.runWithCompilers(['babel-core/register'])
.runWithCompilers(['@babel/register'])
.then((result) => {
console.log(JSON.stringify(result, null, 2));
})
Expand All @@ -23,7 +23,7 @@ pipeline
});

const runner = async () => {
const compilers = ['babel-core/register'];
const compilers = ['@babel/register'];
return initCompilers(compilers)
.then(() =>
configLoader({ fileGlobs: ['../test/pipelines/**/*.config.js'], workingDirectory: __dirname })
Expand Down
2 changes: 0 additions & 2 deletions packages/sitecore-jss-vue/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,11 @@
"url": "https://github.com/sitecore/jss/issues"
},
"devDependencies": {
"@babel/core": "^7.20.12",
Copy link
Contributor Author

@illiakovalenko illiakovalenko Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: These dependencies are unused

"@types/jest": "^29.2.6",
"@types/node": "^18.11.18",
"@vue/compiler-dom": "^3.2.45",
"@vue/test-utils": "2.2.7",
"@vue/vue3-jest": "^29.2.2",
"babel-core": "^6.26.3",
"babel-jest": "^29.5.0",
"del-cli": "^5.0.0",
"eslint": "^8.32.0",
Expand Down
Loading