Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss] Switch to edge site query for XP #1772

Merged
merged 4 commits into from
Apr 16, 2024
Merged

[sitecore-jss] Switch to edge site query for XP #1772

merged 4 commits into from
Apr 16, 2024

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Apr 11, 2024 •
edited
Loading

  • SiteInfoGraphQLService now uses the site query by default for both XP and XMCloud. Search query has been removed.

  • Previously introduced Boolean useSiteQuery switch for XMCLoud users has been removed.

  • This PR follows the Contribution Guide

  • Changelog updated

  • Upgrade guide entry added

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team April 11, 2024 20:39
art-alexeyenko
art-alexeyenko approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on this! I left one small comment to address, and it's ready to merge

docs/upgrades/unreleased.md Outdated Show resolved Hide resolved
@addy-pathania addy-pathania merged commit 54f01a5 into dev Apr 16, 2024
1 check passed
@addy-pathania addy-pathania deleted the feature/jss-1657-switch-site-query branch April 16, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@art-alexeyenko art-alexeyenko art-alexeyenko approved these changes

@yavorsk yavorsk yavorsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addy-pathania @yavorsk @art-alexeyenko