Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retries type #1759

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Fix retries type #1759

merged 2 commits into from
Mar 18, 2024

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Mar 15, 2024 •
edited
Loading

Description / Motivation

retries is coming out to be of type string and number but we need it to be a number explicitly.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team March 15, 2024 14:48
@addy-pathania addy-pathania merged commit 09e6290 into dev Mar 18, 2024
1 check passed
@addy-pathania addy-pathania deleted the bugfix/jss-943-fix-retries branch March 18, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@art-alexeyenko art-alexeyenko art-alexeyenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addy-pathania @art-alexeyenko