Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs] Revert on-demand ISR #1758

Closed
wants to merge 1 commit into from

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Mar 13, 2024

Temporarily revert changes from #1674 until Sitecore CM blockers are addressed.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore

@art-alexeyenko art-alexeyenko requested review from a team and removed request for a team March 13, 2024 19:00
@illiakovalenko
Copy link
Contributor

@art-alexeyenko I think this work was supposed to be done for fork repo. We leave this functionality here and exclude that from the next release

@art-alexeyenko art-alexeyenko deleted the chore/jss-1734-disable-isr-ondemand branch March 14, 2024 12:43
@kendoce
Copy link

kendoce commented Mar 14, 2024

@art-alexeyenko @illiakovalenko - We can still open this PR since we still need to do it for JSS 21.7.0 release.

@art-alexeyenko art-alexeyenko restored the chore/jss-1734-disable-isr-ondemand branch March 18, 2024 14:22
@addy-pathania addy-pathania deleted the chore/jss-1734-disable-isr-ondemand branch March 18, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants