Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Personalize] Remove unused component experiences from layout #1752

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Mar 2, 2024

Description / Motivation

This PR makes sure that any unused personalized variants are deleted before sending layout data to the client, thus are completely hidden from the customer.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate) - Personalize a component in xmcloud and make sure that, when you run your app in production or in vercel, in the layout data json (can be found in the resulting html of the page) does not contain any personalize experiences of the component and personalization works properly;

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@yavorsk yavorsk requested a review from a team March 2, 2024 13:19
CHANGELOG.md Outdated Show resolved Hide resolved
@yavorsk yavorsk requested a review from illiakovalenko March 5, 2024 08:44
@illiakovalenko illiakovalenko merged commit 93e2925 into dev Mar 5, 2024
@illiakovalenko illiakovalenko deleted the feature/JSS-1666 branch March 5, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants