Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss] Add unit tests for retries config #1751

Merged
merged 7 commits into from
Mar 11, 2024
Merged

[sitecore-jss] Add unit tests for retries config #1751

merged 7 commits into from
Mar 11, 2024

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Feb 29, 2024 •
edited
Loading

Description / Motivation

Make sure right config values are used for retries in graphql-request-client

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team February 29, 2024 19:47
illiakovalenko
illiakovalenko approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also, please, verify if debugger is passed in a clientFactory? Otherwise feel free to merge 👍

@addy-pathania addy-pathania merged commit c89d0d1 into dev Mar 11, 2024
1 check passed
@addy-pathania addy-pathania deleted the bugfix/jss-1594-unit-tests branch March 11, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addy-pathania @illiakovalenko