[sitecore-jss] Optimize initial Retry delay time #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addy-pathania
changed the title
delaySeconds
addy-pathania
changed the title
illiakovalenko
requested changes
Feb 13, 2024
art-alexeyenko
requested changes
Feb 13, 2024
art-alexeyenko
approved these changes
Feb 13, 2024
ambrauer
reviewed
Feb 13, 2024
ambrauer
approved these changes
Feb 13, 2024
ambrauer
reviewed
Feb 13, 2024
addy-pathania
added a commit
that referenced
this pull request
Feb 13, 2024
* update delay time to start from 1ms * add tests for DefaultRetryStrategy class * change test description * update changelog * update pretierignore * remove only * add more unit tests, make defaultStrategy class constructor an object * add test for default case
addy-pathania
added a commit
that referenced
this pull request
Feb 22, 2024
* update delay time to start from 1ms * add tests for DefaultRetryStrategy class * change test description * update changelog * update pretierignore * remove only * add more unit tests, make defaultStrategy class constructor an object * add test for default case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, the initial retry delay evaluated to 2 seconds, which becomes relatively high for subsequent retries when assessed in an exponential manner. We aim to initiate the first retry after a 1-second wait instead.
Description / Motivation
Testing Details
Types of changes