Upgrade @graphql-codegen/cli #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavorsk
requested review from
addy-pathania,
illiakovalenko and
art-alexeyenko
illiakovalenko
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Looks good to me! I thought only about one thing that @graphql-codegen/cli has a newer version than other codegen packages (can there be some issues, if they are outdated?), but in general, they don't have peerDependencies, except of graphql. Did you verify that?
Also, fix merge conflicts
|
I agree @illiakovalenko, Its better to upgrade all graphql-codegen packages |
illiakovalenko
approved these changes
Jan 11, 2024
Co-authored-by: Illia Kovalenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
This PR aims to remove few scurity vulnerabilities coming from graphql-codegen/cli by upgrading it to latest
Testing Details
Types of changes