Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Removed "npm" field from "engines" property #1698

Merged
merged 2 commits into from
Dec 15, 2023
Merged

[Chore] Removed "npm" field from "engines" property #1698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99bb6e0
[Chore] Removed "npm" field from "engines" property
illiakovalenko Dec 15, 2023
21660f2
Updated CHANGELOG
illiakovalenko Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Our versioning strategy is as follows:
### 🧹 Chores

* Upgrade to Node.js 20.x ([#1679](https://github.com/Sitecore/jss/pull/1679))([#1681](https://github.com/Sitecore/jss/pull/1681))
* Removed "npm" field from "engines" property ([#1698](https://github.com/Sitecore/jss/pull/1698))

### 🐛 Bug Fixes

Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Want to contribute to Sitecore JavaScript Services? There are a few things you n
## Pre-requisites:

- `node.js` (Use version `>= 18` or [Active LTS](https://nodejs.org/en/about/releases/)) installed (cmd `node -v` to test).
- `npm` (`>= 10`) installed (cmd `npm -v` to test).
- `npm` (`>= 9`) installed (cmd `npm -v` to test).

Install yarn globally:

Expand Down
3 changes: 1 addition & 2 deletions packages/create-sitecore-jss/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
"coverage": "nyc npm test"
},
"engines": {
"node": ">=18",
"npm": ">=10"
"node": ">=18"
},
"repository": {
"type": "git",
Expand Down
3 changes: 1 addition & 2 deletions packages/sitecore-jss-angular-schematics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
"generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-angular-schematics src/jss-component/index.ts --githubPages false"
},
"engines": {
"node": ">=18",
"npm": ">=10"
"node": ">=18"
},
"author": {
"name": "Sitecore Corporation",
Expand Down
3 changes: 1 addition & 2 deletions packages/sitecore-jss-angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
"generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-angular src/public_api.ts --githubPages false"
},
"engines": {
"node": ">=18",
"npm": ">=10"
"node": ">=18"
},
"author": {
"name": "Sitecore Corporation",
Expand Down
3 changes: 1 addition & 2 deletions packages/sitecore-jss-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@
"coverage": "nyc --require ts-node/register/transpile-only npm test"
},
"engines": {
"node": ">=18",
"npm": ">=10"
"node": ">=18"
},
"preferGlobal": true,
"bin": {
Expand Down
3 changes: 1 addition & 2 deletions packages/sitecore-jss-dev-tools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@
"generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-dev-tools src/index.ts --githubPages false"
},
"engines": {
"node": ">=18",
"npm": ">=10"
"node": ">=18"
},
"bin": {
"scjss-deploy": "./dist/cjs/bin/deploy.js",
Expand Down
3 changes: 1 addition & 2 deletions packages/sitecore-jss-forms/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
"generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-forms src/index.ts --githubPages false"
},
"engines": {
"node": ">=18",
"npm": ">=10"
"node": ">=18"
},
"author": {
"name": "Sitecore Corporation",
Expand Down
3 changes: 1 addition & 2 deletions packages/sitecore-jss-nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
"generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-nextjs --entryPoints src/index.ts --entryPoints src/monitoring/index.ts --entryPoints src/editing/index.ts --entryPoints src/middleware/index.ts --entryPoints src/context/index.ts --entryPoints src/utils/index.ts --entryPoints src/site/index.ts --entryPoints src/graphql/index.ts --entryPoints src/revalidate/index.ts --githubPages false"
},
"engines": {
"node": ">=18",
"npm": ">=10"
"node": ">=18"
},
"author": {
"name": "Sitecore Corporation",
Expand Down
3 changes: 1 addition & 2 deletions packages/sitecore-jss-proxy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
"generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-proxy src/index.ts --githubPages false"
},
"engines": {
"node": ">=18",
"npm": ">=10"
"node": ">=18"
},
"author": {
"name": "Sitecore Corporation",
Expand Down
3 changes: 1 addition & 2 deletions packages/sitecore-jss-react-forms/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
"generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-forms src/index.ts --githubPages false"
},
"engines": {
"node": ">=18",
"npm": ">=10"
"node": ">=18"
},
"author": {
"name": "Sitecore Corporation",
Expand Down
3 changes: 1 addition & 2 deletions packages/sitecore-jss-react-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
"generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-react-native src/index.ts --githubPages false"
},
"engines": {
"node": ">=18",
"npm": ">=10"
"node": ">=18"
},
"author": {
"name": "Sitecore Corporation",
Expand Down
3 changes: 1 addition & 2 deletions packages/sitecore-jss-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
"generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-react src/index.ts --githubPages false"
},
"engines": {
"node": ">=18",
"npm": ">=10"
"node": ">=18"
},
"author": {
"name": "Sitecore Corporation",
Expand Down
3 changes: 1 addition & 2 deletions packages/sitecore-jss-rendering-host/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
"generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-rendering-host src/index.ts --githubPages false"
},
"engines": {
"node": ">=18",
"npm": ">=10"
"node": ">=18"
},
"author": {
"name": "Sitecore Corporation",
Expand Down
3 changes: 1 addition & 2 deletions packages/sitecore-jss-vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
"generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-vue src/index.ts --githubPages false"
},
"engines": {
"node": ">=18",
"npm": ">=10"
"node": ">=18"
},
"author": {
"name": "Sitecore Corporation",
Expand Down
3 changes: 1 addition & 2 deletions packages/sitecore-jss/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
"generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss --entryPoints src/index.ts --entryPoints src/graphql/index.ts --entryPoints src/i18n/index.ts --entryPoints src/layout/index.ts --entryPoints src/media/index.ts --entryPoints src/personalize/index.ts --entryPoints src/site/index.ts --entryPoints src/tracking/index.ts --entryPoints src/utils/index.ts --githubPages false"
},
"engines": {
"node": ">=18",
"npm": ">=10"
"node": ">=18"
},
"author": {
"name": "Sitecore Corporation",
Expand Down