Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packages/sitecore-jss-react] Combine fetched and datasource item props in BYOC and FEAAS #1694

Merged
merged 6 commits into from
Dec 14, 2023

Conversation

art-alexeyenko
Copy link
Contributor

Description / Motivation

This is a change to how FEEAS and BYOC handle fetched data.
FEAASComponent:

  • ComponentDataOverride will only be used in server context. No change to functionality, since FEAASComponent is not used directly by Sitecore
  • Data from item datasource is now always used by FEAAS, without overwriting anything from fetched data (rendering params or fetch endpoint)

BYOCComponent:

  • Data from item datasource is now always used by BYOC, without overwriting anything from fetched data

Testing Details

  • Unit Test Adjusted
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested review from a team and Inviz December 14, 2023 16:01
Copy link
Contributor

@Inviz Inviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. good call on adding tests that check that both fields and data works together. I like the simplification of logic.

Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor cleanup noticed otherwise 👍

@art-alexeyenko art-alexeyenko merged commit 1625aa4 into dev Dec 14, 2023
1 check passed
@art-alexeyenko art-alexeyenko deleted the feature/jss-1349-xm-datasource-feaas branch December 14, 2023 18:27
art-alexeyenko pushed a commit that referenced this pull request Dec 14, 2023
art-alexeyenko pushed a commit that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants