-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[packages/sitecore-jss-react] Combine fetched and datasource item props in BYOC and FEAAS #1694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good. good call on adding tests that check that both fields and data works together. I like the simplification of logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor cleanup noticed otherwise 👍
packages/sitecore-jss-react/src/components/FEaaSComponent.test.tsx
Outdated
Show resolved
Hide resolved
…em props in BYOC and FEAAS (#1694)
…ps in BYOC and FEAAS (#1694)
Description / Motivation
This is a change to how FEEAS and BYOC handle fetched data.
FEAASComponent:
BYOCComponent:
Testing Details
Types of changes