Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[templates/nextjs-sxa] fixed request background image if it is empty #1689

Merged
merged 2 commits into from
Dec 12, 2023
Merged

[templates/nextjs-sxa] fixed request background image if it is empty #1689

merged 2 commits into from
Dec 12, 2023

Conversation

sc-ruslanmatkovskyi
Copy link
Collaborator

@sc-ruslanmatkovskyi sc-ruslanmatkovskyi commented Dec 12, 2023 •
edited
Loading

Description / Motivation

When image is empty there was set property background-image. This way made an additional request with status - 404.
Fixed

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko merged commit 69473d0 into dev Dec 12, 2023
1 check was pending
@illiakovalenko illiakovalenko deleted the bugfix/605472-fixed-image-component branch December 12, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sc-ruslanmatkovskyi @illiakovalenko