Revered original empty placeholder output comment

Sitecore · Aug 7, 2024 · 11e03b9 · 11e03b9
1 parent aebec3b
commit 11e03b9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Sitecore.AspNetCore.SDK.RenderingEngine/TagHelpers/PlaceholderTagHelper.cs b/src/Sitecore.AspNetCore.SDK.RenderingEngine/TagHelpers/PlaceholderTagHelper.cs
@@ -109,7 +109,7 @@ public override async Task ProcessAsync(TagHelperContext context, TagHelperOutpu
 
         if (!foundPlaceholderFeatures)
         {
-            output.Content.SetHtmlContent($"<div className=\"sc-jss-empty-placeholder\"></div>");
+            output.Content.SetHtmlContent($"<!-- {string.Format(Resources.Warning_PlaceholderWasEmpty, placeholderName)} -->");
         }
     }
 

diff --git a/...s/Sitecore.AspNetCore.SDK.RenderingEngine.Tests/TagHelpers/PlaceholderTagHelperFixture.cs b/...s/Sitecore.AspNetCore.SDK.RenderingEngine.Tests/TagHelpers/PlaceholderTagHelperFixture.cs
@@ -236,7 +236,7 @@ public async Task ProcessAsync_PlaceholderNameInLayoutServiceResponseAndPlacehol
         await sut.ProcessAsync(tagHelperContext, tagHelperOutput);
 
         // Assert
-        tagHelperOutput.Content.GetContent().Should().Be($"<div className=\"sc-jss-empty-placeholder\"></div>");
+        tagHelperOutput.Content.GetContent().Should().Be($"<!-- Placeholder '{PlaceHolderWithNoComponentsName}' was empty. -->");
     }
 
     [Theory]
-Original file line number
+Diff line change
@@ Expand Up @@
             if (!foundPlaceholderFeatures)
             {
-                output.Content.SetHtmlContent($"<div className=\"sc-jss-empty-placeholder\"></div>");
+                output.Content.SetHtmlContent($"<!-- {string.Format(Resources.Warning_PlaceholderWasEmpty, placeholderName)} -->");
             }
         }
@@ Expand Down @@