generated from Sister20/kit-OS-2023
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback #1
Open
github-classroom
wants to merge
214
commits into
feedback
Choose a base branch
from
main
base: feedback
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splash screennya kerenn gan, congratzz dan ditunggu di next milestone |
@WildanGhaly Valid bit di IDT itu nandai entry-nya ada / engga |
file changed: - interrupt.c info: - to test the program you can do cd path - you can find the example test run on issue section issue: - error handling is still weak
relative pathing is now possible for cd command. Please read each commit message to obtain more information.
file changed: - keyboard.c info: - I am back after 3 weeks but nothing changed on repo -_- - Keyboard disable after some case is fixed - cat is not yet fixed
* feat: add new keyboard isr file changed: - keyboard.c info: - I am back after 3 weeks but nothing changed on repo -_- - Keyboard disable after some case is fixed - cat is not yet fixed * style: add some comment line - nothing much change
- add lots of new system calls - ls is done - cd is done
- mkdir is now runable from user
- cat is now runnable from user
- cp is now runnable in user mode
- rm is now runnable in user mode
- WARNING! Carefull with shell size! - kernel changed due to shell overload - mv is now runnable in user mode
Move user
- lots of files changed :') - now cwd after cd is shown
feat: add cwd
- stack dir was pushed by unknown and make it unsync - now stack dir will always update based on cluster number
- "ls" to show all items in the directory - "ls -a" to show all items in the directory with ext - "ls -f" to show all files in the directory - "ls -ff" to show all files in the directory with ext - "ls -F" to show all folders in the directory
- fix bug when text has no enter
- There was a lot of bug unhandles and now handled - not all test case has been tested
- self cluster wasn't written
Fixing error
Fixing error
feat: add clls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
main
since the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
main
since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main
. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @Darmodar @WildanGhaly @christodharma @AlphaThrone