Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
wants to merge 214 commits into
base: feedback
Choose a base branch
from
Open

Feedback #1

wants to merge 214 commits into from

Conversation

github-classroom[bot]
Copy link

@github-classroom github-classroom bot commented Feb 14, 2023

👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers

Use this PR to leave feedback. Here are some tips:

  • Click the Files changed tab to see all of the changes pushed to main since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.
  • Click the Commits tab to see the commits pushed to main. Click a commit to see specific changes.
  • If you turned on autograding, then click the Checks tab to see the results.
  • This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below.
    For more information about this pull request, read “Leaving assignment feedback in GitHub”.

Subscribed: @Darmodar @WildanGhaly @christodharma @AlphaThrone

@IloveNooodles
Copy link

Splash screennya kerenn gan, congratzz dan ditunggu di next milestone

@Lock1
Copy link

Lock1 commented Mar 23, 2023

@WildanGhaly Valid bit di IDT itu nandai entry-nya ada / engga

WildanGhaly and others added 30 commits April 10, 2023 21:20
file changed:
- interrupt.c

info:
- to test the program you can do cd path
- you can find the example test run on issue section

issue:
- error handling is still weak
relative pathing is now possible for cd command.
Please read each commit message to obtain more information.
file changed:
- keyboard.c
info:
- I am back after 3 weeks but nothing changed on repo -_-
- Keyboard disable after some case is fixed
- cat is not yet fixed
* feat: add new keyboard isr
file changed:
- keyboard.c
info:
- I am back after 3 weeks but nothing changed on repo -_-
- Keyboard disable after some case is fixed
- cat is not yet fixed

* style: add some comment line
- nothing much change
- add lots of new system calls
- ls is done
- cd is done
- mkdir is now runable from user
- cat is now runnable from user
- cp is now runnable in user mode
- rm is now runnable in user mode
- WARNING! Carefull with shell size!
- kernel changed due to shell overload
- mv is now runnable in user mode
- lots of files changed :')
- now cwd after cd is shown
- stack dir was pushed by unknown and make it unsync
- now stack dir will always update based on cluster number
- "ls" to show all items in the directory
- "ls -a" to show all items in the directory with ext
- "ls -f" to show all files  in the directory
- "ls -ff" to show all files in the directory with ext
- "ls -F" to show all folders in the directory
- fix bug when text has no enter
- There was a lot of bug unhandles and now handled
- not all test case has been tested
- self cluster wasn't written
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants