This repository has been archived by the owner on Sep 8, 2022. It is now read-only.
[MIRROR] VIP gets their own department budget than the civilian budget, and gets paid from it. (+department account lock feature) #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts paid from it. (+department account lock feature) (#7330) * vip budget * dd * dd * done * done2 * oops * nope * flex * fixed * cc valid * fix * last fix * deptlock * minor fix (rename define) `department_locked_jobs` to `DEPARTMENT_LOCKED_JOBS` * minor fix (rename define 2) * after fetch * fix * wrong comment * just better not * better comment * nonstation * comment update Co-authored-by: EvilDragonfiend <[email protected]>
…ts paid from it. (+department account lock feature)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: BeeStation/BeeStation-Hornet#7330
About The Pull Request
VIP gets payment from their own department budget than the civilian budget
also, minor fix to cargo ordering app(tablet) along with the new feature
and department lock feature - VIP, Captain, HoS will not get their primary payment department changed. VIP is always from NT budget, Cap and HoS is always from security budget regardless of their newly assigned department.
CMO/CE/RD is still changed because they should see the security budget when they're acting.
Why It's Good For The Game
If HoP and Captain are mean and clever enough, they decrease VIP payment. It's cheating VIPs.
This PR protects VIPs so that they do not lose their wealth.
250 credits aren't enough to flex their real wealth, so some buff to them to 2000 credits since they don't leach station budget anymore. Let's give them REAL WEALTH AND FLEX!
For the credit size, I haven't actually felt they're really wealthy, so 2000 credits would look too much, but I believe they deserve it when we consider they are so special.
department lock feature is just a new feature that follwed after VIP budget thing. actually, it's not that bad to apply it to Captain and HoS, since their paycheck department will be never changed.
Edited
Testing Photographs and Procedure
Screenshots&Videos
VIP card says
The Nanotrasen VIP Expense Account Budgetpayday is fine
This card exists in the code but is spawned in nowhere. only admin can spawn it.
even if their department is changed, it still is in VIP budget.
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.VIP No paycheck in HoP console
cargo ordering app doesn't accept VIP department budget. no bypass.
Changelog
🆑
add: Nanotrasen VIP Expense Account Budget has been added. VIPs will be paid from this budget directly from Nanotrasen rather than the station budget.
tweak: Station heads can't change VIP's payment anymore. (but they can't give bonus to them also.)
tweak: VIP bank accounts are all fixated to Nanotrasen VIP budget department, and changing department will not change their assigned department.
tweak: VIP payment is now 2000 credits, and roundstarts with 10000 credits
tweak: VIP mail from cargo is now yellow
fix: cargo ordering app through a tablet will not accept improper id card
tweak: department change lock feature - even if you change your department, some jobs (VIP, Captain, HoS) don't have a newly changed department as your bank account paying department.
/:cl: