Upgrade 2-4-stable to Solidus #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were uneeded gems just causing problems
We need this just to have access to a working test_app
These files are the entry points into Solidus for gem specific styles and scripts. Without them we get templating errors.
Things have moved around a bit in solidus
Since this gem has no assets anyways I would rather remove this from the rake task than add palceholder files.
These configs no longer work, but we have helpers to do the same.
This line would work in a normal app, but the specs are run in the context of the dummy app, so Rails.root + spec is not going to find anything.
We need these to survive spree's authentication check.
Although nothing requires authentication, we still need to help spree boot up for a request spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only notable changes were
Spree::Config[:site_url] -> current_store.urlandSpree::Config[:site_name] -> current_store.name.