refactor(Pipelines) : Smart Data Frame Pipeline (Sourcery refactored) #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
sourcery-ai
bot
force-pushed
the
sourcery/improvement/refactor_chat
branch
from
dcdfd68 to
4331da9
Compare
|
Important Auto Review SkippedBot user detected. To trigger a single review, invoke the TipsChat with CodeRabbit Bot (
|
sourcery-ai
bot
force-pushed
the
sourcery/improvement/refactor_chat
branch
from
4331da9 to
eb620b0
Compare
sourcery-ai
bot
force-pushed
the
sourcery/improvement/refactor_chat
branch
from
eb620b0 to
d4d494d
Compare
Comment on lines
-40
to
-49
| generate_python_code_instruction = ( | ||
| pipeline_context.query_exec_tracker.execute_func( | ||
| pipeline_context.get_intermediate_value("get_prompt"), | ||
| "generate_python_code", | ||
| default_prompt=GeneratePythonCodePrompt, | ||
| default_values=default_values, | ||
| ) | ||
| return pipeline_context.query_exec_tracker.execute_func( | ||
| pipeline_context.get_intermediate_value("get_prompt"), | ||
| "generate_python_code", | ||
| default_prompt=GeneratePythonCodePrompt, | ||
| default_values=default_values, | ||
| ) | ||
|
|
||
| return generate_python_code_instruction |
There was a problem hiding this comment.
Function PromptGeneration.execute refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
| pipeline_context = PipelineContext([sample_df], config) | ||
| return pipeline_context | ||
| return PipelineContext([sample_df], config) |
There was a problem hiding this comment.
Function TestCodeExecution.context refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
+129
to
+138
|
|
||
| context.get_intermediate_value = Mock(side_effect=mock_intermediate_values) | ||
|
|
||
| assert isinstance(code_execution, CodeExecution) | ||
|
|
||
| result = None | ||
| try: | ||
| result = code_execution.execute(input="Test Code", context=context, logger=logger) | ||
| except Exception as e: | ||
| assert result == None | ||
| assert result is None |
There was a problem hiding this comment.
Function TestCodeExecution.test_code_execution_unsuccessful_after_retries refactored with the following changes:
- Use x is None rather than x == None (
none-compare)
| pipeline_context = PipelineContext([sample_df], config) | ||
| return pipeline_context | ||
| return PipelineContext([sample_df], config) |
There was a problem hiding this comment.
Function TestCodeGenerator.context refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
| pipeline_context = PipelineContext([sample_df], config) | ||
| return pipeline_context | ||
| return PipelineContext([sample_df], config) |
There was a problem hiding this comment.
Function TestResultParsing.context refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-114
to
+127
|
|
||
| context._query_exec_tracker = Mock() | ||
| context.query_exec_tracker.execute_func = Mock(side_effect=mock_result_parsing) | ||
|
|
||
| def mock_intermediate_values(key : str): | ||
| if key == "response_parser" : | ||
| return mock_response_parser | ||
|
|
||
| context.get_intermediate_value = Mock(side_effect=mock_intermediate_values) | ||
|
|
||
| result = None | ||
| try: | ||
| result = result_parsing.execute(input="Test Result", context=context, logger=logger) | ||
| except Exception as e: | ||
| assert result == None | ||
| assert result is None |
There was a problem hiding this comment.
Function TestResultParsing.test_result_parsing_unsuccessful_with_exceptions refactored with the following changes:
- Use x is None rather than x == None (
none-compare)
| pipeline_context = PipelineContext([sample_df], config) | ||
| return pipeline_context | ||
| return PipelineContext([sample_df], config) |
There was a problem hiding this comment.
Function TestResultValidation.context refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-99
to
+98
| assert result == None | ||
| assert result is None |
There was a problem hiding this comment.
Function TestResultValidation.test_result_is_none refactored with the following changes:
- Use x is None rather than x == None (
none-compare)
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## improvement/refactor_chat #740 +/- ##
============================================================
Coverage ? 85.26%
============================================================
Files ? 93
Lines ? 3890
Branches ? 0
============================================================
Hits ? 3317
Misses ? 573
Partials ? 0 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
gventuri
added a commit
that referenced
this pull request
Nov 12, 2023
* refactor(Pipelines) : Smart Data Frame Pipeline * 'Refactored by Sourcery' (#736) Co-authored-by: Sourcery AI <> * refactor(Pipelines) : made changes according to PR review * refactor(Pipelines) : Unit test cases added * refactor(Pipelines) : Unit Test cases added cd /Users/milindlalwani/pandas-ai ; /usr/bin/env /Users/milindlalwani/anaconda3/envs/pandas-ai/bin/python /Users/milindlalwani/.vscode/extensions/ms-python.python-2023.20.0/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher 59121 -- /Users/milindlalwani/pandas-ai/examples/from_csv.py * refactor(Pipelines) : Broken Test Cases Fixed * refactor(Pipelines) : Skip Logic added and More Steps created for Data Smart Lake pipeline * 'Refactored by Sourcery' (#740) Co-authored-by: Sourcery AI <> * refactor: move pipeline logic unit from sdf to pipelines folder * refactor(Pipelines) : Merge Comflicts Fixed * build: fix .lock file --------- Co-authored-by: Milind Lalwani <[email protected]> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Co-authored-by: Gabriele Venturi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #735 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
improvement/refactor_chatbranch, then run:Help us improve this pull request!