Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate CI test and coverage for exposing windows bug #664

Merged
merged 5 commits into from
Oct 22, 2023
Merged

Separate CI test and coverage for exposing windows bug #664

merged 5 commits into from
Oct 22, 2023

Conversation

HenriqueAJNB
Copy link
Contributor

@HenriqueAJNB HenriqueAJNB commented Oct 20, 2023

  • Separate CI test and coverage for exposing Windows bugs.
  • Add virtual environment creating at poetry config.

Notice: This is a breaking change since tests will start failing on Windows!

Summary by CodeRabbit

  • Chore: Updated the Continuous Integration/Continuous Deployment (CI/CD) pipeline for improved clarity and organization. The testing process has been divided into two distinct steps: running the tests and generating a code coverage report. This change enhances the transparency of our testing process and does not affect the functionality of the software.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 20, 2023


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 87dd966 and e5b3a84.
Files ignored due to filter (1)
  • poetry.toml
Files selected for processing (1)
  • .github/workflows/ci.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/ci.yml

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between e5b3a84 and 78df1d5.
Files selected for processing (1)
  • .github/workflows/ci.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/ci.yml

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 78df1d5 and 240caac.
Files selected for processing (1)
  • .github/workflows/ci.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/ci.yml

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Merging #664 (b4c01fd) into main (c66cb06) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
- Coverage   83.97%   83.84%   -0.13%     
==========================================
  Files          67       67              
  Lines        3201     3201              
==========================================
- Hits         2688     2684       -4     
- Misses        513      517       +4     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 20, 2023

This command is invalid for CodeRabbit. Please refer to the list of valid commands under the tips section.

@HenriqueAJNB
Copy link
Contributor Author

@gventuri that is precisely what I mentioned at #663. Now, the related bug is exposed on the Windows platform...

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 20, 2023

This command is invalid for CodeRabbit. Please refer to the list of valid commands under the tips section.

Copy link
Contributor

@nautics889 nautics889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some checks are failed due to known problem described in #661 and #663.

I guess we should also add using of os.path.join in several places:

@HenriqueAJNB
Copy link
Contributor Author

After approving #673, this one can be approved too.

@gventuri gventuri merged commit e005b74 into Sinaptik-AI:main Oct 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants