-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate CI test and coverage for exposing windows bug #664
Separate CI test and coverage for exposing windows bug #664
Conversation
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files ignored due to filter (1)
- poetry.toml
Files selected for processing (1)
- .github/workflows/ci.yml (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/ci.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #664 +/- ##
==========================================
- Coverage 83.97% 83.84% -0.13%
==========================================
Files 67 67
Lines 3201 3201
==========================================
- Hits 2688 2684 -4
- Misses 513 517 +4 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This command is invalid for CodeRabbit. Please refer to the list of valid commands under the tips section. |
This command is invalid for CodeRabbit. Please refer to the list of valid commands under the tips section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After approving #673, this one can be approved too. |
Notice: This is a breaking change since tests will start failing on Windows!
Summary by CodeRabbit