fix[SqlAlchemy]: temporary downgrade sqlalchemy version to support al… #585
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #585 +/- ##
=======================================
Coverage 83.89% 83.89%
=======================================
Files 55 55
Lines 2689 2689
=======================================
Hits 2256 2256
Misses 433 433 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pyproject.toml
Outdated
| @@ -50,9 +50,11 @@ coverage = "^7.2.7" | |||
|
|
|||
| [tool.poetry.group.extras.dependencies] | |||
| google-cloud-aiplatform = "^1.26.1" | |||
| sqlalchemy-databricks = "^0.2.0" | |||
| snowflake-sqlalchemy = "^1.5.0" | |||
There was a problem hiding this comment.
@ArslanSaleem Why are these in the extras and how do the final user installs these?
There was a problem hiding this comment.
Also, beware that sqlalchemy-databricks has been deprecated a while ago (see here).
There was a problem hiding this comment.
@mspronesti thanks for reporting. I think that's the reason of the downgrade, but if an alternative is available we should definitely switch to that.
@ArslanSaleem here's the maintained version, I'll open a issue for that:
https://github.com/databricks/databricks-sql-python
Downgrade SqlAlchemy version to support all connectors