Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.2 #535
Version 1.2 #535
Changes from 13 commits
82d087c
c64f0c6
deb7f20
18e193f
caabd2e
483260c
05810ec
03b8f41
9f94bc4
bae9508
792ae7b
3a92d33
9955000
0223cdf
8d9cd72
f5c4be0
c05733b
223c414
aabd42c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class variables
_config
,_logger
, and_additional_filters
are not typed. It's a good practice to type all variables for better readability and maintainability.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
__init__
method accepts a dictionary as the configuration but the classConnectorConfig
is defined to hold the configuration. It would be better to use this class instead of a dictionary for type safety and better code organization.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The properties
rows_count
,columns_count
, andcolumn_hash
raiseNotImplementedError
. If these methods are mandatory for all subclasses, they should be declared as abstract methods. If they're optional, it would be better to returnNone
instead of raising an error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The property
fallback_name
raisesNotImplementedError
. If this method is mandatory for all subclasses, it should be declared as an abstract method. If it's optional, it would be better to returnNone
instead of raising an error.