Upgrade Modin and pandas versions #1106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
YarShev
commented
Apr 11, 2024
YarShev
commented
- Closes Pandas 2.0 conflicts with the SQL connectors #1085 (Replace xxxx with the GitHub issue number).
- Tests passed if fixing a bug or adding a new feature.
- All code checks passed.
Signed-off-by: Iaroslav Igoshev <[email protected]>
|
Hey folks, I tried to upgrade Modin and pandas versions to latest once again as I didn't see any error in tests locally. Let's see how CI goes. |
|
@YarShev IIRC, the issues were with the SnowFlake connector and probably others as well, but I'm not sure it is highlighted from the tests, as it might be mocked (which is not good, as there should be an error failing because of that, but I'm afraid we don't have a test for that yet). |
|
@gventuri, how did you figure out that there is an issue with the Snowflake connector? Is there an open issue a user filed on this matter? |
|
@ArslanSaleem initially reported it. Maybe he can elaborate further! |
Let's follow up on #1085. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.