Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slugcats as a Species #1353

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Erisfiregamer1
Copy link
Contributor

@Erisfiregamer1 Erisfiregamer1 commented Dec 16, 2024

Description

I've wanted to add Slugcats as a species for a while now. I found myself unable to sleep one night and hastily coded this proof of concept. Please don't merge this for the love of god it is coded terribly.

Why did I pull request this? Mostly just having a record to rant about nonsense I encounter while coding it without clogging up the Discord. I guess you could also review it to maybe help me code less shit.

Credits to Floof for the sounds, sprites, etc as they were all taken from them so I could make something remotely functional.


TODO

  • Make Slugcats a lot less of a unathi copy and paste
  • Iron out that one strange bug in character creation

Media

image

image


Changelog

🆑

  • add: Slugcats are now a species. Wawa.

@github-actions github-actions bot added Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Dec 16, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title Slugcats as a Species [DON'T MERGE THIS] Slugcats as a Species Dec 16, 2024
@bruhmogus
Copy link

eris i know what you're thinking and NO we are not making this a roundstart species on arcadis

@DEATHB4DEFEAT
Copy link
Member

yes you are

@Erisfiregamer1
Copy link
Contributor Author

eris i know what you're thinking and NO we are not making this a roundstart species on arcadis

what death said

@bruhmogus
Copy link

eris i know what you're thinking and NO we are not making this a roundstart species on arcadis

what death said

if you're going to force commit this like everything else at least add back roundstart skeleton first

@Erisfiregamer1
Copy link
Contributor Author

ok :baller:

@github-actions github-actions bot added the Changes: Audio Changes any ogg files label Dec 16, 2024
@Erisfiregamer1
Copy link
Contributor Author

i dont see any major issues with this so if you could take a review at it and check how badly coded it is that would be Very Nice

@Erisfiregamer1 Erisfiregamer1 marked this pull request as ready for review December 17, 2024 22:59
@sleepyyapril
Copy link
Contributor

sleepyyapril commented Dec 22, 2024

i dont see any major issues with this so if you could take a review at it and check how badly coded it is that would be Very Nice

the yaml linter fail:

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@BlueHNT
Copy link
Contributor

BlueHNT commented Jan 4, 2025

wawa

Any species unique actions or specialties? Also wouldn't they be entirely mute as shown in rainworld?

@Erisfiregamer1
Copy link
Contributor Author

wawa

Any species unique actions or specialties? Also wouldn't they be entirely mute as shown in rainworld?

From what little we know, they can make SOME vocalizations, so I just locked them to a language only they understand.

As for species unique actions, I haven't thought of anything specific yet. At the moment they are simply a hard-mode species by default, dying far easier to most things.

@BlueHNT
Copy link
Contributor

BlueHNT commented Jan 5, 2025

wawa
Any species unique actions or specialties? Also wouldn't they be entirely mute as shown in rainworld?

From what little we know, they can make SOME vocalizations, so I just locked them to a language only they understand.

As for species unique actions, I haven't thought of anything specific yet. At the moment they are simply a hard-mode species by default, dying far easier to most things.

fast lil wawa creatures with anger issues and bonus to spears

@BlueHNT
Copy link
Contributor

BlueHNT commented Jan 5, 2025

Still a few outlying yaml issues

Error: /Prototypes/Entities/Mobs/Species/slugcat.yml(85,17)  PrototypeID nullification for type Content.Shared.Inventory.InventoryTemplatePrototype at Line: 85, Col: 17 not found
Error: /Prototypes/Entities/Mobs/Species/slugcat.yml(-1,-1)  PrototypeID nullification for type Content.Shared.Inventory.InventoryTemplatePrototype at Line: -1, Col: -1 not found

no clue what integration tests are saying though.

Copy link
Contributor

@BlueHNT BlueHNT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.wav files for the wawa_exclaim.wav wawa_question.wav and wawa_statement.wav should be converted to .ogg format

@BlueHNT
Copy link
Contributor

BlueHNT commented Jan 5, 2025

Alright, found the issue... It's breaking the usual format of going into species/parts.rsi as it doesn't have the location.
image
image
While it normally looks as
image
image

So the scug probably needs to be seperated into parts and stitched together properly, else the shitmed won't work either and the said scug will have no hands/legs.

Alternativelly becoming simplemob.

@Erisfiregamer1
Copy link
Contributor Author

Alright, found the issue... It's breaking the usual format of going into species/parts.rsi as it doesn't have the location. image image While it normally looks as image image

So the scug probably needs to be seperated into parts and stitched together properly, else the shitmed won't work either and the said scug will have no hands/legs.

Alternativelly becoming simplemob.

This was hacked up within 24 hours and I wasn't able to sprite anything (and I am Absolute Shit at spriting anyway). Once I sprite it I'll add the proper files.

Copy link
Contributor

@Aidenkrz Aidenkrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These really shouldn't be roundstart, especially when their main feature is "Oni melee but only spears" they fit much better as a kobold/monkey alternative. If you really want you could make a pun pun style ghost role for cargo or something. You should also try to just use monkey displacement maps for slugcats, it would probably work.

@Erisfiregamer1
Copy link
Contributor Author

Erisfiregamer1 commented Jan 5, 2025

These really shouldn't be roundstart

Yeah no I did not intend them to be roundstarts. They're only roundstart for testing.

they fit much better as a kobold/monkey alternative.

That is also true, I just found it easier to make them a species (and funnier)

If you really want you could make a pun pun style ghost role for cargo or something.

If this is even considered to be merged, maybe.

You should also try to just use monkey displacement maps for slugcats, it would probably work.

Already do.

@Aidenkrz Aidenkrz marked this pull request as draft January 17, 2025 20:46
@BlueHNT
Copy link
Contributor

BlueHNT commented Jan 19, 2025

Each day I look at this PR. Really looking forward to it.

@Erisfiregamer1
Copy link
Contributor Author

Each day I look at this PR. Really looking forward to it.

While they aren't coming as a (roundstart) species, I could probably add them as a base mob :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any ogg files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Status: Do Not Merge Do not merge Status: Merge Conflict FIX YOUR PR AAAGH
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants