Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker nats-server to testing environment #62

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pizzaluc
Copy link
Collaborator

How was this tested?

  • Step one etc.

Type of change

Please check all boxes that apply to this change below.

Type Applies ✅
Backend
Frontend
Github/Ci/Admin
Documentation required

Checklist

Please follow the checklist below and check all completed items as you work on the PR.

I have..

  • performed a self-review of my own code
  • commented my code, particularly in hard-to-understand areas
  • written documentation
  • added automated tests
  • merged dependencies to `develop

@pizzaluc pizzaluc force-pushed the testing/docker branch 8 times, most recently from 136b40b to c4813a0 Compare April 23, 2021 09:54
@Maasdamind
Copy link
Collaborator

@pizzaluc anything missing here or is it ready for review?

@pizzaluc
Copy link
Collaborator Author

@pizzaluc anything missing here or is it ready for review?

well, nothing is really missing. The test is kinda work in progress, but that is probably better fit for another pull request. So you can review it

@pizzaluc pizzaluc marked this pull request as ready for review April 28, 2021 12:36
Copy link
Collaborator

@TKShade TKShade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. How does the changes to EventParser relate to the testing? Don't know this part of the code.

@pizzaluc
Copy link
Collaborator Author

pizzaluc commented May 6, 2021

Looks good to me. How does the changes to EventParser relate to the testing? Don't know this part of the code.

The current code is only able to use the NATS_URL in the .env, i dont know if this is the best way to refactor it, but its necessarry if you wanna spin up a test instance that uses different option parameters

@EDBM EDBM self-requested a review May 17, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants