Fix magic number based descriptor variants #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix fast sbsp definition having incorrect name for surfaces reflexive(missing an 's')
Moved several sub-descriptors out of parent descriptor to easily reuse in os_v3/4 defs Removed useless comments
Fix haloscript descriptor variant using magic indices
Fixed halo1_rsrc_map descriptor using magic indices
|
Not sure how to split this into multiple pull requests, but if you want that for ease of testing, I can shelve the changes, delete the branch, and push them out over the next few weeks or something. |
|
I'm just gonna close this and do it in pieces. I'm leaving the branch around for source control until I'm done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening the pull request early because of how big it is so it can be looked over sooner. This is what I was doing yesterday.
There are potential issues in
os_v4_hek/defs/scnr.pyandos_v4_hek/defs/unit.pythat you may want to look at @gbMichelle . Please don't bite my head offCloses #63