Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenLayers 6.14.1 and ol-ext 3.2.22 #84

Merged
merged 61 commits into from
Apr 17, 2022
Merged

OpenLayers 6.14.1 and ol-ext 3.2.22 #84

merged 61 commits into from
Apr 17, 2022

Conversation

smellman
Copy link
Contributor

@smellman smellman commented Apr 4, 2022

This WIP PR contains following:

  • Remove types-ol because OpenLayers supports TypeScript
  • version up npm packages
  • change on/once/un types

@smellman
use ol 6.14.1's type declaration(drop using ol-types) and fix types f…
860ebba 
…or EditBar, update to ol-ext 3.2.22
@smellman
bump npm packages
0862351
@smellman
use current dtslint(but it doesn't run)
f45daa8
@smellman
use OnSignature
47c26e1
@smellman
use OnSignature
291446d
@smellman
use OnSignature
fefb473
@smellman
use OnSignature
f52c8b3
@smellman
test: use typeof
10e0350
@smellman
remove unused import
7bcaec7
@smellman
use geojson package because openlayers upstream use it
a8a6d49
@smellman
use OnSignature
96b20f3
@smellman
use OnSignature
6f078df
@smellman
use OnSignature
2bdee33
@smellman
use OnSignature
0cf589b
@smellman
use OnSignature
3bb1933
@smellman
use OnSignature
0a3a218
@smellman
use OnSignature
4e99a13
@smellman
use OnSignature
8e52ca8
@smellman
use OnSignature
ab28425
@smellman
use OnSignature
dfabd7d
@smellman
use OnSignature
dcaadab
@smellman
use OnSignature
2da0d1b
@smellman
use OnSignature
bab9c6d
@smellman
set UIEvent argument
7e2361f
@smellman
use typeof for namespace to fix TS2709
9998139
@smellman
use typeof
450f84b
@smellman
import LineString to fix compile error
d975ddf
@smellman
fixes interface declare
e5787ec
Siedlerchr
Siedlerchr reviewed Apr 4, 2022
View reviewed changes
@types/ol-ext/interaction/TouchCursorDraw.d.ts
@@ -13,7 +13,7 @@ export interface Options extends InteractionOptions {
coordinate?: Coordinate;
buttons?: Button[];
maxButtons?: number;
type?: GeometryType;
type?: typeof GeometryType;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice! I think that was one of the things where I struggled when I tried to use the native OL version types!

@Siedlerchr
Copy link
Owner

Thank you very much! This will help a lot. A while ago, I already looked into trying to make it work with the native types of OL, but could not make it work. So thanks again!

@smellman smellman marked this pull request as ready for review April 13, 2022 05:38
@smellman
Copy link
Contributor Author

I tested all examples.
Note: I set "skipLibCheck": false in tsconfig.json because geotiff package raise TypeScript errors.
Btw, to find TypeScript error, this value to true is better.

@sanak sanak requested review from Siedlerchr and sanak April 17, 2022 03:52
@sanak sanak mentioned this pull request Apr 17, 2022
Open
@sanak
Copy link
Collaborator

sanak commented Apr 17, 2022

@smellman (CC: @Siedlerchr)
Thanks for upgrading and improving this library !
I confirmed that all examples except #85 work correctly.
(About featureanimation, just recovering comment block is enough, I think.)

@Siedlerchr
I am not so familiar with TypeScript changing part, but I confirmed that current examples work without error, so I think that this is safe to merge.

Siedlerchr
Siedlerchr approved these changes Apr 17, 2022
View reviewed changes
Copy link
Owner

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your work on this! This is really a huge improvement!

@Siedlerchr Siedlerchr merged commit 7c4942b into Siedlerchr:master Apr 17, 2022
@sanak sanak mentioned this pull request Apr 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanak sanak sanak left review comments

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smellman @Siedlerchr @sanak