-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(sdk): Add support for signing v2 transactions #873
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I'll give it a go and see if I hit any issues.
Just need to fix an issue with the commit formatting 😆:
feat(sdk): add support for signing v2 transactions
error:
⧗ input: feature(sdk): Add support for signing v2 transactions
✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]
✖ type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum]
✖ found 2 problems, 0 warnings
1ed0bbe
to
c6db29f
Compare
c6db29f
to
1ee2cf9
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1ee2cf9
to
09b0ea7
Compare
Signing v2 transactions has a slightly different flow and structure from V1.
I'm hoping you'll be able to use this API to construct the transaction instead of using
/fund
and/fundsf
separately: SiaFoundation/walletd#211The request body is the Siacoin and Siafund recipients. The response is an unsigned transaction.