Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(renterd): files and uploads pagination and other tests #868

Merged
merged 1 commit into from
Dec 20, 2024
Merged

test(renterd): files and uploads pagination and other tests #868

merged 1 commit into from
Dec 20, 2024

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Dec 20, 2024 •
edited
Loading

  • Tests for renterd files and uploads pagination.
  • Test for hostd contracts and volumes pagination.
  • e2e: Added support for uploading files of a specific size.

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hostd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 7:54pm
renterd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 7:54pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 7:54pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 7:54pm
website ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 7:54pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: f2b790f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@siafoundation/design-system Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This was referenced Dec 20, 2024
Merged
Merged
Merged
Merged
@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Dec 20, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@alexfreska alexfreska mentioned this pull request Dec 20, 2024
Merged
@alexfreska alexfreska requested a review from peterjan December 20, 2024 16:21
@alexfreska alexfreska mentioned this pull request Dec 20, 2024
Merged
@alexfreska alexfreska force-pushed the refactor_visible_columns branch from 5a8824d to 66ee1aa Compare December 20, 2024 16:31
@alexfreska alexfreska force-pushed the test_renterd_files_and_uploads_pagination branch from 853b556 to 52637b5 Compare December 20, 2024 16:31
peterjan
peterjan approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 did you play test it on a renterd instance or should I?

@alexfreska alexfreska force-pushed the test_renterd_files_and_uploads_pagination branch 2 times, most recently from 775c8cd to dee1c65 Compare December 20, 2024 17:18
@alexfreska alexfreska force-pushed the refactor_visible_columns branch from 66ee1aa to 6c1081e Compare December 20, 2024 17:24
@alexfreska alexfreska force-pushed the test_renterd_files_and_uploads_pagination branch from dee1c65 to 12caf96 Compare December 20, 2024 17:24
@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Dec 20, 2024 •
edited
Loading

@peterjan yes I've run these locally and these run on the CI, I'm currently tweaking this stack of PRs so all the affected tests are happy, but these ones addressing the bugs are looking good.

@alexfreska alexfreska force-pushed the refactor_visible_columns branch from 6c1081e to fc26807 Compare December 20, 2024 17:41
@alexfreska alexfreska force-pushed the test_renterd_files_and_uploads_pagination branch from 12caf96 to e0968af Compare December 20, 2024 17:41
@alexfreska alexfreska force-pushed the refactor_visible_columns branch 2 times, most recently from 8e9c27a to 438b71b Compare December 20, 2024 17:58
@alexfreska alexfreska force-pushed the test_renterd_files_and_uploads_pagination branch 2 times, most recently from 472887c to 70c1729 Compare December 20, 2024 18:05
@alexfreska alexfreska force-pushed the test_renterd_files_and_uploads_pagination branch from 70c1729 to e1c62e3 Compare December 20, 2024 18:40
@alexfreska alexfreska changed the title test(renterd): files and uploads pagination test(renterd): files and uploads pagination and other tests Dec 20, 2024
@alexfreska alexfreska force-pushed the test_renterd_files_and_uploads_pagination branch from e1c62e3 to a0ca12d Compare December 20, 2024 19:25
@alexfreska Graphite App
Copy link
Member Author

alexfreska commented Dec 20, 2024 •
edited
Loading

Merge activity

  • Dec 20, 2:43 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 20, 2:45 PM EST: Graphite rebased this pull request as part of a merge.
  • Dec 20, 2:46 PM EST: A user merged this pull request with Graphite.

@alexfreska alexfreska changed the base branch from refactor_visible_columns to graphite-base/868 December 20, 2024 19:43
@alexfreska alexfreska changed the base branch from graphite-base/868 to main December 20, 2024 19:43
@alexfreska alexfreska force-pushed the test_renterd_files_and_uploads_pagination branch from a0ca12d to f2b790f Compare December 20, 2024 19:44
@alexfreska alexfreska merged commit e983c15 into main Dec 20, 2024
11 of 33 checks passed
@alexfreska alexfreska deleted the test_renterd_files_and_uploads_pagination branch December 20, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjan peterjan peterjan approved these changes

Assignees

@alexfreska alexfreska

Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexfreska @peterjan