-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove chain_indices
table
#107
Conversation
The failure in The easiest way to solve this problem is to add a Regardless, I'm all for removing the |
28957fc
to
80f1337
Compare
@n8maninger this PR now removes the |
This PR removes the
chain_indices
table. I'm not entirely sure that's what we want but since we were discussing getting rid of theCASCADE
deletes I don't see a good reason to keep the table. Creating it and linking it is more of a nuisance than anything else imo, if you don't get the upside of the cascaded deletes.I hit an interesting test failure in the process, an underflow is triggered in
TestEphemeralBalance
which is interesting because onmaster
there are no orphaned indices, but now there are orphanedsiacoin_elements
... so I'm a little bit puzzled still on why that is.I think there might also be a bug in
RevertOrphans
because we loop over the orphaned indices and it seems we only deal with the balances of the last orphan. (consensus.go:751) Since I'm not sure whether we want to get rid of thechain_indices
entirely I'm going to keep it inDRAFT
until tomorrow when Nate is back from being OOO.