Allow for setting user metadata when completing a multipart upload #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
reviewed
Mar 12, 2024
ChrisSchinnerl
force-pushed
the
chris/multipart-complete-user-meta
branch
from
81217dc to
4648806
Compare
peterjan
approved these changes
Mar 13, 2024
|
Can you please update the API documentation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the minio client allows for passing user metadata when completing a multipart upload but our handler didn't accept user metadata. This PR updates our endpoint and
backend.goto merge any metadata provided when finishing a Multipart Upload into the object as well.Depends on SiaFoundation/gofakes3#5