Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix superfluous header being returned on failed download #3

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix superfluous header being returned on failed download #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions gofakes3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,9 +515,11 @@ func (g *GoFakeS3) getObject(
obj.Range.writeHeader(obj.Size, w)

if _, err := io.Copy(w, obj.Contents); err != nil {
return err
// Log this failure but return 'nil'. We have already started sending
// data so we can't send an error response anymore anyway.
g.log.Print(LogErr, "error copying object contents", err)
return nil
}

return nil
}

Expand Down