Use coreutils/wallet.Event #149
Open
+595
−361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is pretty rough. I'm leaning towards using the extended types. They are close enough matches that it will probably be fine. |
👍 With you on that. I guess we can still use wallet.Event but the implementing types will be different. |
|
Started on this but it has me thinking. When we do unconfirmed events, aren't we going to have to convert from the core types into the explorer types? Because we're going to be taking transactions that haven't been indexed yet more or less straight from the txpool. Except we might not have all the info to fill out the "enhanced" fields for the explorer types. |
chris124567
force-pushed
the
christopher/use-wallet-event
branch
from
37bd37b to
134f5ba
Compare
chris124567
force-pushed
the
christopher/use-wallet-event
branch
from
134f5ba to
9e5777a
Compare
chris124567
requested review from
n8maninger
and removed request for
n8maninger
… types already describe the value of SC/SF inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the standard event type used in our other apps. Unfortunately to avoid duplicating queries this requires some conversions from explorer types to core types. Alternatively, we could just use the enhanced explorer types for the transaction and resolution events which would make things somewhat easier.Use standard event types from used in other apps, but with explorer type versions of the fields rather than the core versions.
Fix #78