-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 changes #129
Merged
Merged
V2 changes #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris124567
force-pushed
the
v2
branch
3 times, most recently
from
November 6, 2024 18:05
f3fe466
to
1ed0892
Compare
…fill in fields on a slice of txns rather than returning and passing around maps
…g into siacoin_elements and siafund_elements to get correct id in cases where we update instead of insert
…nputs for v1 transactions too
ChrisSchinnerl
previously approved these changes
Nov 20, 2024
peterjan
reviewed
Nov 20, 2024
n8maninger
previously approved these changes
Nov 20, 2024
chris124567
dismissed stale reviews from n8maninger and ChrisSchinnerl
via
November 20, 2024 23:31
8f52f3c
n8maninger
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging ground for v2 changes
All of the changes merged into here were individually reviewed previously so a review is not strictly required here but if anyone has any final comments that would be fine too.
This implements:
#63
#62