Fix tpool race #89
Merged
Fix tpool race #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8maninger
force-pushed
the
nate/tpool-race
branch
from
19176a9 to
654082d
Compare
ChrisSchinnerl
previously approved these changes
Aug 26, 2024
peterjan
reviewed
Aug 26, 2024
n8maninger
force-pushed
the
nate/tpool-race
branch
from
a4a305e to
7754053
Compare
ChrisSchinnerl
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition primarily seen when exchanging v2 transaction sets in RHP4. The renter sends the host a transaction set with a particular basis. If the tip changes before the RPC completes and the transaction includes ephemeral outputs, the transaction set will be invalidated and the RPC will fail. This fixes that race by changing the tpool to update the ephemeral state elements and proofs when updating the transaction set basis.