refactor(tests): update snapshots and clean indicators for consistency

src/__snapshots__/check.test.ts.snap

@@ -252,7 +252,7 @@ exports[`check C ts-project folder 1`] = `
     "package-json-could-have-a-check-script-like-check-pnpm-build-pnpm-lint",
     "package-json-could-have-a-final-echo-for-task-build-build-echo-wsbuild-w",
     "package-json-one-coverage-dependency-from-nyc-c8-v8",
-    "package-json-could-have-latest-version-of-repo-checker-like-repo-check-1-39-43m30m-fixable-39m49m",
+    "package-json-could-have-latest-version-of-repo-checker-like-repo-check-x-yy-43m30m-fixable-39m49m",
     "package-json-ts-node-without-transpile-only-detected-in-files-package-json",
     "package-json-could-have-not-fat-ts-runner-use-typescript-run-like-dev-ts-run-src-watch-or-ts-run-src-w-src-another-folder-not-fat-ts-runner-use-typescript-run-like-dev-ts-run-src-watch-or-ts-run-src-w-src-another-folder",
     "readme-md-could-have-a-logo-image-logofolder-any-file-ext",
@@ -345,7 +345,7 @@ exports[`check E mocks-projects folders and not throw 1`] = `
     "package-json-could-have-a-check-script-like-check-pnpm-build-pnpm-lint",
     "package-json-could-have-a-final-echo-for-task-build-build-echo-wsbuild-w",
     "package-json-one-coverage-dependency-from-nyc-c8-v8",
-    "package-json-could-have-latest-version-of-repo-checker-like-repo-check-1-39-43m30m-fixable-39m49m",
+    "package-json-could-have-latest-version-of-repo-checker-like-repo-check-x-yy-43m30m-fixable-39m49m",
     "package-json-ts-node-without-transpile-only-detected-in-files-package-json",
     "package-json-could-have-not-fat-ts-runner-use-typescript-run-like-dev-ts-run-src-watch-or-ts-run-src-w-src-another-folder-not-fat-ts-runner-use-typescript-run-like-dev-ts-run-src-watch-or-ts-run-src-w-src-another-folder",
     "readme-md-could-have-a-logo-image-logofolder-any-file-ext",

src/check.test.ts

@@ -1,7 +1,7 @@
 import { expect, it } from 'vitest'
 import { check } from './check'
 import { ProjectData, repoCheckerPath } from './constants'
-import { mocksProjectsFolder, tsProjectFolder } from './mock'
+import { cleanIndicatorsForSnap, mocksProjectsFolder, tsProjectFolder } from './mock'
 
 it('check A repo-checker folder fails with low max size', async () => {
   const data = new ProjectData({ isPublishedPackage: true, isQuiet: true, maxSizeKo: 2 })
@@ -13,13 +13,13 @@ it('check A repo-checker folder fails with low max size', async () => {
 it('check B repo-checker folder succeed', async () => {
   const data = new ProjectData({ isModule: true, isPublishedPackage: true, isQuiet: true, maxSizeKo: 120 })
   const indicators = await check({ data, folderPath: repoCheckerPath })
-  expect(indicators).toMatchSnapshot()
+  expect(cleanIndicatorsForSnap(indicators)).toMatchSnapshot()
 })
 
 it('check C ts-project folder', async () => {
   const data = new ProjectData({ isQuiet: true })
   const indicators = await check({ canThrow: false, data, folderPath: tsProjectFolder })
-  expect(indicators).toMatchSnapshot()
+  expect(cleanIndicatorsForSnap(indicators)).toMatchSnapshot()
 })
 
 it('check D mocks-projects folders and throw', async () => {
@@ -32,5 +32,5 @@ it('check D mocks-projects folders and throw', async () => {
 it('check E mocks-projects folders and not throw', async () => {
   const data = new ProjectData({ isQuiet: true })
   const indicators = await check({ canFailStop: true, canThrow: false, data, folderPath: mocksProjectsFolder })
-  expect(indicators).toMatchSnapshot()
+  expect(cleanIndicatorsForSnap(indicators)).toMatchSnapshot()
 })

src/files/__snapshots__/package.test.ts.snap

@@ -77,7 +77,7 @@ exports[`package A on repo checker 1`] = `
   ],
   "warnings": [
     "package-json-main-file-maximum-size-is-specified-in-data-file-ex-max-size-ko-100",
-    "package-json-could-have-latest-version-of-repo-checker-like-repo-check-1-39-43m30m-fixable-39m49m",
+    "package-json-could-have-latest-version-of-repo-checker-like-repo-check-x-yy-43m30m-fixable-39m49m",
   ],
 }
 `;
@@ -196,7 +196,7 @@ exports[`package B on ts project 1`] = `
     "package-json-could-have-a-check-script-like-check-pnpm-build-pnpm-lint",
     "package-json-could-have-a-final-echo-for-task-build-build-echo-wsbuild-w",
     "package-json-one-coverage-dependency-from-nyc-c8-v8",
-    "package-json-could-have-latest-version-of-repo-checker-like-repo-check-1-39-43m30m-fixable-39m49m",
+    "package-json-could-have-latest-version-of-repo-checker-like-repo-check-x-yy-43m30m-fixable-39m49m",
     "package-json-ts-node-without-transpile-only-detected-in-files-package-json",
     "package-json-could-have-not-fat-ts-runner-use-typescript-run-like-dev-ts-run-src-watch-or-ts-run-src-w-src-another-folder-not-fat-ts-runner-use-typescript-run-like-dev-ts-run-src-watch-or-ts-run-src-w-src-another-folder",
   ],
@@ -327,7 +327,7 @@ exports[`package C ts project isUsing* 1`] = `
     "package-json-could-have-a-check-script-like-check-pnpm-build-pnpm-lint",
     "package-json-could-have-a-final-echo-for-task-build-build-echo-wsbuild-w",
     "package-json-one-coverage-dependency-from-nyc-c8-v8",
-    "package-json-could-have-latest-version-of-repo-checker-like-repo-check-1-39-43m30m-fixable-39m49m",
+    "package-json-could-have-latest-version-of-repo-checker-like-repo-check-x-yy-43m30m-fixable-39m49m",
     "package-json-ts-node-without-transpile-only-detected-in-files-package-json",
     "package-json-could-have-not-fat-ts-runner-use-typescript-run-like-dev-ts-run-src-watch-or-ts-run-src-w-src-another-folder-not-fat-ts-runner-use-typescript-run-like-dev-ts-run-src-watch-or-ts-run-src-w-src-another-folder",
     "package-json-could-have-a-module-field-pointing-to-an-esm-mjs-like-module-dist-index-mjs",
@@ -474,7 +474,7 @@ exports[`package E vue project 1`] = `
     "package-json-could-have-a-check-script-like-check-pnpm-build-pnpm-lint",
     "package-json-one-unit-testing-dependency-from-vitest-mocha-uvu",
     "package-json-one-coverage-dependency-from-nyc-c8-v8",
-    "package-json-could-have-latest-version-of-repo-checker-like-repo-check-1-39-43m30m-fixable-39m49m",
+    "package-json-could-have-latest-version-of-repo-checker-like-repo-check-x-yy-43m30m-fixable-39m49m",
   ],
 }
 `;

src/mock.ts

@@ -4,8 +4,21 @@ import path from 'node:path'
 import { clone, sleep } from 'shuutils'
 import type { FileBase } from './file'
 import { join } from './utils'
+import type { check } from './check'
 
-const baseKeys: (keyof FileBase)[] = ['fileExists', 'checkFileExists', 'folderPath', 'inspectFile', 'updateFile', 'initFile']
+const fileBaseKeysToDelete: (keyof FileBase)[] = ['fileExists', 'checkFileExists', 'folderPath', 'inspectFile', 'updateFile', 'initFile']
+const indicatorsKeys: ReadonlyArray<keyof Awaited<ReturnType<typeof check>>> = ['failed', 'passed', 'warnings'] as const
+
+function cleanStringForSnap(input: string) {
+  return input.replace(/repo-check-\d-\d+/gu, 'repo-check-x-yy') // replace repo-check-1-40 by repo-check-x-yy
+}
+
+function cleanUnknownValueForSnap<Type>(input: Type): Type {
+  if (typeof input === 'string') return cleanStringForSnap(input) as Type
+  if (Array.isArray(input)) return input.map(cleanUnknownValueForSnap) as Type
+  if (typeof input === 'object') return JSON.parse(cleanStringForSnap(JSON.stringify(input))) as Type
+  throw new Error(`cleanInstanceValueForSnap: unknown type ${typeof input}`)
+}
 
 export async function promiseValue<Type>(value: Type) {
   await sleep(1)
@@ -37,10 +50,14 @@ export const mocksProjectsFolder = join(sourceFolder, 'mocks')
 
 // eslint-disable-next-line @typescript-eslint/prefer-readonly-parameter-types
 export function cleanInstanceForSnap(instance: Readonly<FileBase>, ...bonusKeys: readonly string[]) {
-  const clean = clone<Partial<FileBase>>(instance)
-  // eslint-disable-next-line @typescript-eslint/consistent-type-assertions, @typescript-eslint/no-dynamic-delete
-  for (const key of baseKeys) delete (clean as Record<string, unknown>)[key]
-  // eslint-disable-next-line @typescript-eslint/no-dynamic-delete, @typescript-eslint/consistent-type-assertions
-  for (const key of bonusKeys) if (key in clean) delete (clean as Record<string, unknown>)[key]
+  const clean = clone<Partial<FileBase>>(instance) as Record<string, unknown>
+  const keys = [...fileBaseKeysToDelete, ...bonusKeys] // eslint-disable-next-line @typescript-eslint/no-dynamic-delete, @typescript-eslint/consistent-type-assertions
+  for (const key of keys) if (key in clean) delete (clean as Record<string, unknown>)[key]
+  return cleanIndicatorsForSnap(clean)
+}
+
+export function cleanIndicatorsForSnap(record: Record<string, unknown>) {
+  const clean = clone(record)
+  for (const key of indicatorsKeys) if (key in clean) clean[key] = cleanUnknownValueForSnap(clean[key])
   return clean
 }