Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear the QR code matrix underneath the logo, fix #15 #16

Merged
merged 2 commits into from
Sep 1, 2024

Conversation

kostia1st
Copy link
Contributor

A few important comments as to what and why was done here:

  • I noticed that the codebase in its current state is quite uneven, and to a degree does not follow its own prettier rules. So I had to apply prettier selectively where it was touching my changes. I tried to reduce unnecessary changes.
  • I increased the printWidth setting for prettier to 120, as it seems like the code informally follows that rule anyway.
  • before, logoWidth & logoHeight were a percentage of the entire image, which I found very inconvenient to think of, and quite unhandy in code logic. Thus I changed it so now that width and height are proportional to the actual matrix size, leaving margin out of the equasion. Which means, changing margin no longer affects logo and QR code blocks intersection logic, and logo always stays the same relative to the actual QR code.
  • I did rename a few local variables here and there, since I found the previous names a bit confusing, especially the units applied to the values in question. Hope that's OK.

@kostia1st
Copy link
Contributor Author

This one's to fix #15

@gugu gugu merged commit 9f4c31d into Short-io:master Sep 1, 2024
4 checks passed
Copy link

github-actions bot commented Sep 1, 2024

🎉 This issue has been resolved in version 9.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants