Clear the QR code matrix underneath the logo, fix #15 #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few important comments as to what and why was done here:
printWidth
setting forprettier
to120
, as it seems like the code informally follows that rule anyway.logoWidth
&logoHeight
were a percentage of the entire image, which I found very inconvenient to think of, and quite unhandy in code logic. Thus I changed it so now that width and height are proportional to the actual matrix size, leavingmargin
out of the equasion. Which means, changingmargin
no longer affects logo and QR code blocks intersection logic, and logo always stays the same relative to the actual QR code.