Merge pull request #83 from Shopify/make-scrub-iterative

Make scrub be iterative instead of recursive so it does not throw a stack level too deep error for big experiments

lib/verdict/storage/redis_storage.rb

@@ -67,15 +67,17 @@ def scope_key(scope)
       end
 
       def scrub(scope, cursor: 0)
-        cursor, results = redis.with do |conn|
-          conn.hscan(scope_key(scope), cursor, count: PAGE_SIZE)
-        end
+        loop do
+          cursor, results = redis.with do |conn|
+            conn.hscan(scope_key(scope), cursor, count: PAGE_SIZE)
+          end
 
-        results.map(&:first).each do |key|
-          remove(scope, key)
-        end
+          results.map(&:first).each do |key|
+            remove(scope, key)
+          end
 
-        scrub(scope, cursor: cursor) unless cursor.to_i.zero?
+          break if cursor.to_i.zero?
+        end
       end
     end
   end