Fetch metafield definitions on start-up

[aswamy]

What are you adding in this PR?

Part of #502

• Adding the ability to fetch metafield definitions on VSCode startup
• Does not check the version of the CLI
• Timeouts if the CLI does not complete the action

Tophat

Unfortunately, the CLI does not contain the metafield definitions pull command yet. To tophat the change override the path variable to use a locally built version of CLI of the main branch.

E.g.

const  path = '<path-to-cli-repo>/packages/cli/bin/dev.js';

What's next? Any followup issues?

• Should we be adding .shopify/metafields.json as part of gitignore for themes?

Before you deploy

• I included a minor bump changeset

[aswamy]

The current CLI does not have the ability to pull metafields, so tophat this build the CLI PR here and hardcode this value to the path.

E.g.

const path = '<where-ever-you-cloned-it>/cli/packages/cli/bin/dev.js'

[charlespwd]

I think this should somehow be injected in startServer's fetchMetafieldsForURI injection.

IIRC the metafields should be loaded per theme root, not per workspace.

I don't 100% know how the shopify cli works and if there's an auth per theme, but I don't think someone running a monorepo will necessarily have the same metafield definitions for shop A & shop B

[aswamy]

@charlespwd Should we also only do this if we're working with themes, and not theme app extensions?

[charlespwd]

Should we also only do this if we're working with themes, and not theme app extensions?

I think so. At least until we validate we have a solution for them. Can they even use metafields? Probably?

We do have a getModeForURI: Promise<'theme' | 'app'> in the language server, but it depends on how we load the config. Probably going to be fun (not) to use that from the outside. 😓

[aswamy]

Update

• Made sure we only fetch metafields using CLI if it's a theme, not a theme app or anything else
• Made sure we only fetch metafields using CLI when called from node environment
• Fetch metafield definitions for each workspace folder + any folder that get's added dynamically to the workspace