Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reporting the same Bundler install error twice #3033

Merged

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented Jan 9, 2025

Motivation

If bundle install fails and one of the gems ends up not being present, then Bundler.setup is guaranteed to fail with Bundler::GemNotFound, but that's expected. The root cause of the problem is the fact that installation failed.

Let's not set setup_error in that particular case to avoid reporting the same issue twice to telemetry.

Implementation

Started not setting setup_error if there was an install_error and the error during setup matches the expected class.

@vinistock vinistock added bugfix This PR will fix an existing bug server This pull request should be included in the server gem's release notes labels Jan 9, 2025 — with Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock requested review from andyw8 and st0012 January 9, 2025 17:22
@vinistock vinistock marked this pull request as ready for review January 9, 2025 17:23
@vinistock vinistock requested a review from a team as a code owner January 9, 2025 17:24
@vinistock vinistock merged commit 41fceb9 into main Jan 9, 2025
43 checks passed
Copy link
Member Author

Merge activity

  • Jan 9, 1:50 PM EST: A user merged this pull request with Graphite.

@vinistock vinistock deleted the 01-09-avoid_reporting_the_same_bundler_install_error_twice branch January 9, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR will fix an existing bug server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants