Avoid reporting the same Bundler install error twice #3033
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If bundle install fails and one of the gems ends up not being present, then
Bundler.setup
is guaranteed to fail withBundler::GemNotFound
, but that's expected. The root cause of the problem is the fact that installation failed.Let's not set
setup_error
in that particular case to avoid reporting the same issue twice to telemetry.Implementation
Started not setting
setup_error
if there was aninstall_error
and the error during setup matches the expected class.