Add GotoTest and GotoSource functionality #2985
Draft
+131
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenny-codes
force-pushed
the
goto-test
branch
2 times, most recently
from
811dca1 to
b362347
Compare
Define and implement the experimental/gotoRelevantFile lsp method. This request takes in a textDcoument param, and retusn an array of locations that are related to the input file path. Currently, the related file paths are - test files, if the input file is a source file - source files, if the input file is a test file Basically it goes between source file <> test file. This is implemented as a experimental method until something more official comes along.
jenny-codes
force-pushed
the
goto-test
branch
from
b362347 to
da1a48d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A stab at #2966. We can now click the "Goto Test" and "Goto Source" from the commands menu and from the explorer view.
Implementation
Implementing it as a custom request for now until vscode starts supporting it officially.
The path finding algorithm is a rephrase of https://github.com/jasonrudolph/significant-other-vscode/blob/main/matchmaker.js
https://github.com/shopify/dev-test-runner seems to have a more robust implementation though. I'm also going to explore some other options too before deciding on the final implementation.
Automated Tests
Not yet!
Manual Tests
rubylsp-goto-2.mp4