Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Check if RuboCop is available before searching for add-on (#3071)
### Motivation This is a fix for the bug I just introduced in #3067 🤦♂️. We cannot assume that the `RuboCop` constant will be defined because projects may use a different formatter. We need to check first. ### Implementation Started checking if the constant we need is defined as part of the check. ### Automated Tests Part of why this wasn't caught is because our integration tests were ignoring the response return for the initialize request. That makes the tests extremely weak because the LSP will actually rescue anything that happens during initialize and then simply return an error back to the client, which means that tests passed despite initialization failing. I started properly checking for what response was returned, so that we can fail tests if initialization was not successful. Without the fix, tests now properly fail.
- Loading branch information