Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@remote-dom/[email protected]
Patch Changes
#499
994e2ea
Thanks @lemonmade! - Roll back mutation ofglobalThis
andglobalThis.self
inWindow.setGlobal()
This prevents the polyfill from interfering with globals like
globalThis.addEventListener
, which you may need to manage the communication between a sandboxed environment and the main thread.In the future, we will likely change the polyfill to require you to explicitly install the polyfill, instead of it being done automatically when you
@remote-dom/core/polyfill
. At that point, we will reintroduce the ability to more faithfully replicate more DOM globals, like havingglobalThis
,globalThis.self
, andglobalThis.window
all refer to the same polyfilledWindow
object. To install this polyfill today and get back to the behavior introduced by this PR, you can call the newWindow.setGlobalThis()
method:#465
017ca02
Thanks @lemonmade! - Fixslot
to be transmitted as an attribute, not a propertyUpdated dependencies [
994e2ea
]:@remote-dom/[email protected]
Patch Changes
#499
994e2ea
Thanks @lemonmade! - Roll back mutation ofglobalThis
andglobalThis.self
inWindow.setGlobal()
This prevents the polyfill from interfering with globals like
globalThis.addEventListener
, which you may need to manage the communication between a sandboxed environment and the main thread.In the future, we will likely change the polyfill to require you to explicitly install the polyfill, instead of it being done automatically when you
@remote-dom/core/polyfill
. At that point, we will reintroduce the ability to more faithfully replicate more DOM globals, like havingglobalThis
,globalThis.self
, andglobalThis.window
all refer to the same polyfilledWindow
object. To install this polyfill today and get back to the behavior introduced by this PR, you can call the newWindow.setGlobalThis()
method:@remote-dom/[email protected]
Patch Changes
#465
017ca02
Thanks @lemonmade! - Fixslot
to be transmitted as an attribute, not a propertyUpdated dependencies [
994e2ea
,017ca02
]:[email protected]
Patch Changes
994e2ea
,017ca02
]:[email protected]
Patch Changes
994e2ea
,017ca02
]:[email protected]
Patch Changes
994e2ea
,017ca02
]: