Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature, Add support to show CTAs button on group tooltips #1765

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Passanelli
Copy link
Collaborator

@Passanelli Passanelli commented Nov 26, 2024

What does this implement/fix?

This PR adds support for the feedback received from Glen and Cynthia during OK2 session.

  • Add support to show CTAs buttons on tooltips when available
  • Deselect groups when clicking outside Grid chart

Does this close any currently open issues?

Ticket https://github.com/orgs/Shopify/projects/10349/views/1?pane=issue&itemId=88576072&issue=Shopify%7Crfm-pipeline%7C126

Storybook link

Tophat link url

Before merging

  • Check your changes on a variety of browsers and devices.
  • Update the Changelog's Unreleased section with your changes.
  • Update relevant documentation, tests, and Storybook.
  • Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package

@Passanelli Passanelli self-assigned this Nov 26, 2024
@Passanelli Passanelli force-pushed the passanelli/add_support_for_actions branch from d175d90 to 3bdac6f Compare November 26, 2024 14:51
Copy link

github-actions bot commented Nov 26, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.64 KB (0%) 1.3 s (0%) 766 ms (-36.6% 🔽) 2 s
polaris-viz-cjs 224.06 KB (+0.21% 🔺) 4.5 s (+0.21% 🔺) 2.2 s (+18.18% 🔺) 6.6 s
polaris-viz-esm 181.33 KB (+0.25% 🔺) 3.7 s (+0.25% 🔺) 1.5 s (+1.91% 🔺) 5.1 s
polaris-viz-css 5.68 KB (+2.34% 🔺) 114 ms (+2.34% 🔺) 355 ms (-28.6% 🔽) 468 ms
polaris-viz-esnext 188.23 KB (+0.32% 🔺) 3.8 s (+0.32% 🔺) 1.7 s (+42.61% 🔺) 5.5 s

@Passanelli Passanelli force-pushed the passanelli/add_support_for_actions branch 2 times, most recently from 328a989 to 37027ef Compare November 26, 2024 15:20
@Passanelli Passanelli marked this pull request as ready for review November 26, 2024 16:31
@Passanelli Passanelli force-pushed the passanelli/add_support_for_actions branch 3 times, most recently from c5dbf9d to 30c5126 Compare November 26, 2024 18:04
@Passanelli Passanelli force-pushed the passanelli/add_support_for_actions branch from 30c5126 to 19bf433 Compare November 26, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants