Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ordering of workspaces in package.json to reflect folder order #2636

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lb-
Copy link

@lb- lb- commented Nov 7, 2024

WHY are these changes introduced?

To make it easier for developers to cross-reference the workspaces, it would be good to have these sorted alphabetically. Similar to how folders would be ordered.

WHAT is this pull request doing?

Adjusts package.json to have an alphabetical sorting for workspaces.

Before

Observe the ordering of examples is ad-hoc/inconsistent.
Screenshot 2024-11-07 at 12 30 11 PM

After

Observe the ordering is now the same as the folders.
Screenshot 2024-11-07 at 11 56 13 AM

HOW to test your changes?

The ordering of the workspaces does not have impacts on dependencies between packages, running tests & checks should be sufficient.

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes N/A
  • I've added tests to cover my changes N/A
  • I've added or updated the documentation N/A

@lb-
Copy link
Author

lb- commented Nov 7, 2024

I have signed the CLA!

@lb- lb- force-pushed the cleanup/revise-ordering-package-json-workspaces branch from 9a65562 to 1846bd6 Compare November 7, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant